[PATCH] D144800: [DebugInfo] Remove `dbg.addr` from CodeGen

[J. Ryan Stinnett via Phabricator via llvm-commits]

jryans marked an inline comment as done.
jryans added inline comments.


================
Comment at: llvm/test/DebugInfo/X86/merge-equivalent-ranges.ll:31
   store i32 %CUID, ptr %CUID.addr, align 4
   call void @llvm.dbg.value(metadata ptr %CUID.addr, metadata !16, metadata !DIExpression(DW_OP_deref)), !dbg !17
   call void @llvm.dbg.value(metadata ptr %CUID.addr, metadata !26, metadata !DIExpression(DW_OP_deref, DW_OP_stack_value)), !dbg !17
----------------
StephenTozer wrote:
> For the purposes of this test, we can also remove this line and the test for "Var1" above - since this test is testing that this range merges with the one that is being deleted, the test isn't meaningful anymore; ideally we'd have a good way to test this otherwise, but don't consider it a blocker on this patch.
Ah hmm, what if instead of removing the `dbg.addr` below, I were to replace it with `dbg.declare`...? Would that preserve the full meaning of this test?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144800/new/

https://reviews.llvm.org/D144800