[PATCH] D144638: [lit] Detect Inconsistent File Access Times

Michael Platings via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 27 06:48:15 PST 2023


michaelplatings added a comment.

I see some of these tests previously had `UNSUPPORTED: system-netbsd` but not `UNSUPPORTED: system-windows` - do you know why?



================
Comment at: llvm/utils/lit/lit/llvm/config.py:190
+                return False
+            if "1995" not in touch_res_out:
+                return False
----------------
This could end up matching the wrong part of the string, for example if the temporary file happened to have 1995 in its name. A regex match for '\b1995\b' would be more reliable.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144638/new/

https://reviews.llvm.org/D144638



More information about the llvm-commits mailing list