[PATCH] D144671: [InstCombine] prevent miscompiles from select-of-div/rem transform

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 27 06:08:09 PST 2023


spatel added a comment.

In D144671#4154013 <https://reviews.llvm.org/D144671#4154013>, @efriedma wrote:

> Alternatively, if you freeze the condition of the select, the transform is legal in all cases.

Thanks! Yes, that's the likely better fix. This transform does get rid of a div/rem, so that's a potentially big win vs. adding a freeze.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144671/new/

https://reviews.llvm.org/D144671



More information about the llvm-commits mailing list