[PATCH] D144682: Fix miscompilation from MergeFunctions-Inline-SROA-InstCombine optimization sequence

Mon Feb 27 05:33:08 PST 2023

dingxiangfei2009 added inline comments.

================
Comment at: llvm/test/Transforms/MergeFunc/mergefunc-preserve-nonnull.ll:10
+
+define hidden void @f1(ptr noalias nocapture noundef sret(%1) dereferenceable(24) %0, ptr noalias nocapture noundef dereferenceable(24) %1) unnamed_addr #0 {
+  ; CHECK-LABEL: @f1(
----------------
nikic wrote:
> There are a lot of attributes and instructions in this test that can be dropped -- we don't need much more than the the load instructions that can't be merged. See also https://llvm.org/docs/TestingGuide.html#best-practices-for-regression-tests.
@nikic Thanks for the tip! I have reduce the test to reflect the new changes. Does it look reasonable to you?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144682/new/

https://reviews.llvm.org/D144682