[PATCH] D144720: [AVR] Fix incorrect flags of livein registers when spilling them

Ben Shi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 27 04:23:19 PST 2023


benshi001 marked 2 inline comments as done.
benshi001 added inline comments.


================
Comment at: llvm/lib/Target/AVR/AVRFrameLowering.cpp:268
+        STI.getRegisterInfo()->splitReg(livein.PhysReg, LoSub, HiSub);
+        if (Reg == HiSub || Reg == LoSub) {
+          MBB.addLiveIn(Reg);
----------------
jacquesguan wrote:
> Could we use `isSubRegister` to check if it is a subreg?
Thanks. This `isSubRegister` really make code more clear.



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144720/new/

https://reviews.llvm.org/D144720



More information about the llvm-commits mailing list