[PATCH] D144848: [SCEV] Skip instrs with non-scevable types in forget[Loop,Value].

[Max Kazantsev via Phabricator via llvm-commits]

mkazantsev added a comment.

I'm not 100% sure



================
Comment at: llvm/include/llvm/Analysis/ScalarEvolution.h:2049
+#ifndef NDEBUG
+  /// Iterate over instructions in \p Worlist and their users. Assert all users
+  /// have been removed from ValueExprMap.
----------------
typo: `Worlist -> Worklist`


================
Comment at: llvm/lib/Analysis/ScalarEvolution.cpp:8467
+    if (!isSCEVable(I->getType()))
+      continue;
+    assert(ValueExprMap.count(I) == 0 &&
----------------
nikic wrote:
> Hm, isn't the verification supposed to omit this check?
I guess we can skip it. We can't have them in `ValueExprMap` anyways.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144848/new/

https://reviews.llvm.org/D144848