[PATCH] D140369: [PowerPC] update PPCTTIImpl::supportsTailCallFor() check conditions
Ting Wang via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Feb 27 03:04:31 PST 2023
tingwang added inline comments.
================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:5664
+ Arg.hasAttribute(Attribute::Preallocated))
+ IsByValArg = true;
+
----------------
shchenz wrote:
> Should this be on PPC target only or it should be a target independent check? `shouldBeMustTail` checks some target independent conditions.
Yeah, these checks are already covered by `shouldBeMustTail`, and could be redundant. I removed the check and updated the patch. Thank you!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140369/new/
https://reviews.llvm.org/D140369
More information about the llvm-commits
mailing list