[PATCH] D144638: [lit] Detect Consistent File Access Times

[Michael Platings via Phabricator via llvm-commits]

michaelplatings added a comment.

Thanks very much for looking into this, the flakiness of these tests has been bugging me for ages.



================
Comment at: llvm/utils/lit/lit/llvm/config.py:171
+            # in the tests that do the same thing.
+            (_, try_touch_err) = self.get_process_output(["touch", "-a", "-t", "199505050555.55", f.name])
+            if try_touch_err != "":
----------------
It looks like this command will be run on Windows. I think it will fail and cause False to be returned, which is the desired result, but this appears to be by accident rather than design. Therefore I'm inclined to agree with @int3 that a hard-coded check would be preferable.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144638/new/

https://reviews.llvm.org/D144638