[PATCH] D144857: [llvm-debuginfo-analyzer] README

Carlos Alberto Enciso via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 27 02:06:07 PST 2023


CarlosAlbertoEnciso added a comment.

These are the next 2 patches:

  //===----------------------------------------------------------------------===//
  // Remove the use of macros in 'LVReader.h' that describe the bumpallocators.
  //===----------------------------------------------------------------------===//
  https://reviews.llvm.org/D137933#inline-1389904
  
  Use a standard (or LLVM) map with typeinfo (would need a specialization
  to expose equality and hasher) for the allocators and the creation
  functions could be a function template.
  
  //===----------------------------------------------------------------------===//
  // Use a lit test instead of a unit test for the logical readers.
  //===----------------------------------------------------------------------===//
  https://reviews.llvm.org/D125783#inline-1324376
  
  As the DebugInfoLogicalView library is sufficiently exposed via the
  llvm-debuginfo-analyzer tool, follow the LLVM general approach and
  use LIT tests to validate the logical readers.
  
  Convert the unitests:
    llvm-project/llvm/unittests/DebugInfo/LogicalView/CodeViewReaderTest.cpp
    llvm-project/llvm/unittests/DebugInfo/LogicalView/ELFReaderTest.cpp
  
  into LIT tests:
    llvm-project/llvm/test/DebugInfo/LogicalView/CodeViewReader.test
    llvm-project/llvm/test/DebugInfo/LogicalView/ELFReader.test


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144857/new/

https://reviews.llvm.org/D144857



More information about the llvm-commits mailing list