[PATCH] D144792: [DebugInfo][Docs] Remove `dbg.addr` from docs

[Orlando Cazalet-Hyams via Phabricator via llvm-commits]

Orlando added a comment.

SGTM

I wonder if it's worth leaving a dbg.addr section in here as a migration guide for front ends that use it (or perhaps a release note would be sufficient - we should probably include a release note either way).

Additionally IMO it could be worth writing up another discourse post with a title that conveys the intention to remove dbg.addr to ensure no one feels caught out, linking to the existing discourse discussion. YMMV.



================
Comment at: llvm/docs/SourceLevelDebugging.rst:203
     ; The address of i is buffer+64.
-    call void @llvm.dbg.addr(metadata [256 x i8]* %buffer, metadata !3,
-                             metadata !DIExpression(DW_OP_plus, 64)), !dbg !4
+    call void @llvm.dbg.declare(metadata [256 x i8]* %buffer, metadata !3,
+                               metadata !DIExpression(DW_OP_plus, 64)), !dbg !4
----------------
I guess we should update the docs to use opaque pointers in these examples (e.g. `metadata ptr %buffer`) but that is probably something for a seperate patch, since there are parts that need updating other than the bits you're touching here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144792/new/

https://reviews.llvm.org/D144792