[PATCH] D144733: [ARM] Add Thumb Attributes for thumb thunks created in SLSHarding

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 27 01:29:22 PST 2023


dmgreen added a comment.

In D144733#4154514 <https://reviews.llvm.org/D144733#4154514>, @DavidSpickett wrote:

> Looks good but where are the tests?

Oh. The test is that we turn on ARM_MC::verifyInstructionPredicates and it doesn't it asserts in the existing tests, especially llvm/test/CodeGen/ARM/speculation-hardening-sls-boththunks.ll. I think this is the last piece that is missing from the llvm-tests. I can try and see if I can make something more specific to this change.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144733/new/

https://reviews.llvm.org/D144733



More information about the llvm-commits mailing list