[PATCH] D140369: [PowerPC] update PPCTTIImpl::supportsTailCallFor() check conditions

[ChenZheng via Phabricator via llvm-commits]

shchenz added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:5664
+        Arg.hasAttribute(Attribute::Preallocated))
+      IsByValArg = true;
+
----------------
Should this be on PPC target only or it should be a target independent check? `shouldBeMustTail` checks some target independent conditions.


================
Comment at: llvm/test/Transforms/Coroutines/coro-split-musttail-ppc64le.ll:13
+; RUN: opt < %s -passes='cgscc(coro-split),simplifycfg,early-cse' -S \
+; RUN:     -mtriple=ppc32-- | FileCheck %s
 
----------------
nit: `ppc32--` and `powerpc--` should both be for PPC arch (32 bit, BE), I think just one line is needed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140369/new/

https://reviews.llvm.org/D140369