[PATCH] D144779: [X86] Add tests for replacing `{v}permilps` -> `{v}shufps/{v}pshufd`; NFC

[Noah Goldstein via Phabricator via llvm-commits]

goldstein.w.n added a comment.

In D144779#4153399 <https://reviews.llvm.org/D144779#4153399>, @RKSimon wrote:

> In D144779#4153376 <https://reviews.llvm.org/D144779#4153376>, @RKSimon wrote:
>
>> In D144779#4152876 <https://reviews.llvm.org/D144779#4152876>, @goldstein.w.n wrote:
>>
>>> In D144779#4152616 <https://reviews.llvm.org/D144779#4152616>, @RKSimon wrote:
>>>
>>>> You might be better off splitting this into tuning-shuffle-permilps.ll (although keep AVX512 test coverage here as well) and tuning-shuffle-permilps-avx512.ll
>>>
>>> What do you mean? As in move the masked-predicate versions to a seperate test file and keep `avx512` targets? Or something else?
>>
>> The 512-bit and masked predicate cases - I'm also concerned whether the Z128/Z256 cases are being correctly tested or the evex-vec pass has already converted them to the regular xmm/ymm variants
>
> The tuning pass is before evex-vex so we should be OK - it might be worth adding to the avx512 file a single additional RUN for "-mcpu=x86-86-v4 --show-mc-encoding" that greps that we have no "EVEX TO VEX Compression" strings

I don't think this works. Even if x86fixupinsttuning runs first, even to vex compression will eventually run and be in the output.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144779/new/

https://reviews.llvm.org/D144779