[PATCH] D144442: [X86] Add tests for replacing `{v}unpck{l|h}pd` -> `{v}shufps`; NFC

Noah Goldstein via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Feb 26 10:47:53 PST 2023


goldstein.w.n added a comment.

In D144442#4153406 <https://reviews.llvm.org/D144442#4153406>, @RKSimon wrote:

> Also, this should block D144570 <https://reviews.llvm.org/D144570> and not D144779 <https://reviews.llvm.org/D144779>/D144570 <https://reviews.llvm.org/D144570> - ideally we're going to want D144570 <https://reviews.llvm.org/D144570> to be in trunk for a few days before any follow ups to shake out any unexpected regressions to prevent a nasty long chain of reversions, which is why I'm so keen to get accepted patches in early instead of you stacking them all up.

Hmm? You repeat D144570 <https://reviews.llvm.org/D144570> for block/non-block.

D143786 <https://reviews.llvm.org/D143786> -> D143859 <https://reviews.llvm.org/D143859> -> D144779 <https://reviews.llvm.org/D144779> -> D143787 <https://reviews.llvm.org/D143787> -> D144442 <https://reviews.llvm.org/D144442> -> D144570 <https://reviews.llvm.org/D144570> seems like the order to me. We can wait after D143787 <https://reviews.llvm.org/D143787> or D144570 <https://reviews.llvm.org/D144570>. Whichever you prefer.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144442/new/

https://reviews.llvm.org/D144442



More information about the llvm-commits mailing list