[PATCH] D144451: [X86] Optimize umax(X,1)

Sun Feb 26 09:45:56 PST 2023

goldstein.w.n added a comment.

In D144451#4153259 <https://reviews.llvm.org/D144451#4153259>, @kazu wrote:

> In D144451#4142960 <https://reviews.llvm.org/D144451#4142960>, @RKSimon wrote:
>
>> Do we have i8/i16 test coverage anywhere?
>
> I just checked in 86bd9c984154d625392bfab05541bbe9ee18b6ab <https://reviews.llvm.org/rG86bd9c984154d625392bfab05541bbe9ee18b6ab>.  This patch being reviewed here does not handle i8/i16 yet.

Think might make sense to move this to `LowerSELECT` so it can handle i8/i16. Also makes more sense to just lower this directly to adc/sbb rather than through cmovcc.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144451/new/

https://reviews.llvm.org/D144451