[PATCH] D144053: [LICM] Ensure LICM can hoist invariant.group

William Moses via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Feb 26 09:44:21 PST 2023


wsmoses added a comment.

I'm personally of the opinion that building a special case for an illegal use of the invariant metadata (e.g. where it would guarantee the memory is not changed), would produce more fragile code -- since it'll be harder for someone who accidentally creates such illegal metadata to find the actual source of the bug.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144053/new/

https://reviews.llvm.org/D144053



More information about the llvm-commits mailing list