[PATCH] D132455: [ADT] add ConcurrentHashtable class.

[Alexey Lapshin via Phabricator via llvm-commits]

avl added a comment.

@aprantl  @JDevlieghere @dblaikie @MaskRay Would you mind to take a look at this review, please?

The performance comparison for this hash table for reading strings from DWARF info from clang binary(done by utility from D132548 <https://reviews.llvm.org/D132548>):

  --num-threads 16
  
                               time      memory
  1. llvm-concurrent-hashmap: 0.82 sec     3.1G
  2. lldb-const-string:       0.98 sec     3.1G
  
  
  --num-threads 1
  
                               time      memory
  1. llvm-concurrent-hashmap: 5.7 sec     3.1G
  2. lldb-const-string:       7.1 sec     3.1G
  3. llvm-string-map:         5.7 sec     3.1G

The advantages comparing to lldb-const-string implementation:

1. ConcurrentHashTableByPtr is general. It might be used not only for strings.
2. ConcurrentHashTableByPtr has a bit better performance numbers.
3. ConcurrentHashTableByPtr is more scalable.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132455/new/

https://reviews.llvm.org/D132455