[PATCH] D144779: [X86] Add tests for replacing `{v}permilps` -> `{v}shufps/{v}pshufd`; NFC
Simon Pilgrim via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Feb 26 03:43:58 PST 2023
RKSimon added a comment.
In D144779#4152876 <https://reviews.llvm.org/D144779#4152876>, @goldstein.w.n wrote:
> In D144779#4152616 <https://reviews.llvm.org/D144779#4152616>, @RKSimon wrote:
>
>> You might be better off splitting this into tuning-shuffle-permilps.ll (although keep AVX512 test coverage here as well) and tuning-shuffle-permilps-avx512.ll
>
> What do you mean? As in move the masked-predicate versions to a seperate test file and keep `avx512` targets? Or something else?
The 512-bit and masked predicate cases - I'm also concerned whether the Z128/Z256 cases are being correctly tested or the evex-vec pass has already converted them to the regular xmm/ymm variants
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144779/new/
https://reviews.llvm.org/D144779
More information about the llvm-commits
mailing list