[PATCH] D143637: StackProtector: add unwind cleanup paths for instrumentation.

[Xiang Zhang via Phabricator via llvm-commits]

xiangzhangllvm added inline comments.


================
Comment at: llvm/lib/CodeGen/DwarfEHPrepare.cpp:297
 bool DwarfEHPrepare::InsertUnwindResumeCalls() {
+  if (F.hasPersonalityFn() &&
+      StackProtector::requiresStackProtector(&F, nullptr))
----------------
I just header the func __gxx_personality_v0  in **libc++** will handle the exception. 
Does all the callees in the caller (with personality attribute) may do invisible unwinds for exception ? So you visibly generate the cleanup resume (to let current stack protect can see it then generate protection code. )


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143637/new/

https://reviews.llvm.org/D143637