[PATCH] D136400: [llvm-ocaml] Migrate from naked pointers to prepare for OCaml 5

[Alan via Phabricator via llvm-commits]

alan added a comment.

I feel a little bit apprehensive about the lack of `CAML` macros in some places. After this patch is done, I think it might be worth it to review the code and make a patch that:

- Adds `CAML` macros if there are any places we left them out but shouldn't have
- Add comments documenting the justification for being loose with the OCaml runtime API rules (e.g. that using `Field` to initialize an allocation from `caml_alloc_tuple_uninit` is safe because you are never storing a pointer in it, or that omitting `CAMLlocal` is safe when the variable is only used to store the result of calling the OCaml runtime API).

Do you think this is necessary or advisable?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136400/new/

https://reviews.llvm.org/D136400