[PATCH] D139092: [LLD][ELF] Cortex-M Security Extensions (CMSE) Support

Amilendra Kodithuwakku via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Feb 25 07:39:05 PST 2023


amilendra marked an inline comment as done.
amilendra added inline comments.


================
Comment at: lld/ELF/Arch/ARM.cpp:1035
+    // Symbol must have external linkage.
+    StringRef name = acleSeSym->getName();
+    name.consume_front(ACLESESYM_PREFIX);
----------------
MaskRay wrote:
> `StringRef name = acleSeSym->getName().substr(ACLESESYM_PREFIX.size());`
> `StringRef name = acleSeSym->getName().substr(ACLESESYM_PREFIX.size());`

`ACLESESYM_PREFIX.size()` gives `error: member reference base type 'const char [11]' is not a structure or union` 
I can use `strlen(ACLESESYM_PREFIX)` though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139092/new/

https://reviews.llvm.org/D139092



More information about the llvm-commits mailing list