[PATCH] D144776: [X86][MC] Early bail out in emitREXPrefix, NFCI
Phoebe Wang via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Feb 25 06:17:43 PST 2023
pengfei accepted this revision.
pengfei added a comment.
This revision is now accepted and ready to land.
LGTM.
================
Comment at: llvm/lib/Target/X86/MCTargetDesc/X86MCCodeEmitter.cpp:1197
+ llvm_unreachable("Unexpected form in emitREXPrefix!");
+ else
+ break;
----------------
We don't need the else here.
================
Comment at: llvm/lib/Target/X86/MCTargetDesc/X86MCCodeEmitter.cpp:1198
+ else
+ break;
+ case X86II::RawFrmMemOffs:
----------------
This can also be `[[fallthrough]];`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144776/new/
https://reviews.llvm.org/D144776
More information about the llvm-commits
mailing list