[PATCH] D144783: [ELF] Move getSectionAndRelocations to ELF.cpp from ELFDumper.cpp

Aiden Grossman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Feb 25 02:54:14 PST 2023


aidengrossman added reviewers: tmsriram, rahmanl, shenhan.
aidengrossman added a comment.

This is the refactoring of `getSectionsAndRelocations` requested in https://reviews.llvm.org/D143841. I've put it in a separate patch to try and keep things a little bit more manageable. I still need to add some test cases (probably unit tests) for the failure modes since I've changed it around quite a bit (new failure modes + older failure modes would only report a text warning rather than returning an `Error`). Other than that though, this patch should be good to go for review.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144783/new/

https://reviews.llvm.org/D144783



More information about the llvm-commits mailing list