[PATCH] D144221: [amdgpu][nfc] Replace ad hoc LDS frame recalculation with absolute_symbol MD
Jon Chesterfield via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Feb 25 02:38:56 PST 2023
JonChesterfield added inline comments.
================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUMachineFunction.h:108
void allocateKnownAddressLDSGlobal(const Function &F);
+ static std::optional<uint32_t> parseSingleOperandMetadata(MDNode *MD);
----------------
Might be better to specialise this to take a global, check for absolute_symbol and rename the function to match. optional<uint32> getAbsoluteSymbolMetadata(const GlobalVariable *) perhaps.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144221/new/
https://reviews.llvm.org/D144221
More information about the llvm-commits
mailing list