[PATCH] D144563: [SimplifyCFG] Improve the precision of `PtrValueMayBeModified`

[Dávid Bolvanský via Phabricator via llvm-commits]

xbolva00 accepted this revision.
xbolva00 added a comment.

Precommit tests?

Otherwise looks good.



================
Comment at: llvm/lib/Transforms/Utils/SimplifyCFG.cpp:7126
+        // getelementptr (TY, null, 0)                 -> null
+        // getelementptr (TY, null, not zero)          -> maybe be modified
+        // getelementptr inbounds (TY, null, 0)        -> null
----------------
may be?


================
Comment at: llvm/lib/Transforms/Utils/SimplifyCFG.cpp:7128
+        // getelementptr inbounds (TY, null, 0)        -> null
+        // getelementptr inbounds (TY, null, not zero) -> poison? (only if null
+        // is undefined)
----------------
poison? (only if null is undefined)

why question mark? Maybe:

poison iff null is undefined?




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144563/new/

https://reviews.llvm.org/D144563