[PATCH] D144353: [lld][RISCV] Avoid error when encountering unrecognised ISA extensions/versions in RISC-V attributes

Fri Feb 24 22:16:56 PST 2023

asb added inline comments.

================
Comment at: llvm/unittests/Support/RISCVISAInfoTest.cpp:22
+TEST(ParseNormalizedArchString, RejectsUpperCase) {
+  for (auto Input : {"RV32", "rV64", "rv32i2P0", "rv64i2p0_A2p0"}) {
+    EXPECT_EQ(
----------------
MaskRay wrote:
> s/auto/StringRef/
> 
> https://llvm.org/docs/CodingStandards.html#use-auto-type-deduction-to-make-code-more-readable
I've gone ahead and changed these, but I do consider this a case of "the type is already obvious from the context" and hence in-line with the recommendation. Clearly not a big deal either way.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144353/new/

https://reviews.llvm.org/D144353