[PATCH] D143787: [X86] Add new pass `X86FixupInstTuning` for fixing up machine-instruction selection.

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon requested changes to this revision.
RKSimon added a comment.
This revision now requires changes to proceed.

someting I just noticed - please can you ensure you have AVX1 test coverage for the VPERMILPSmi/VPERMILPSYmi cases - we can't fold the VPERMILPSYmi case to the VPSHUDYmi which requires AVX2



================
Comment at: llvm/lib/Target/X86/X86FixupInstTuning.cpp:115
+  case X86::VPERMILPSYmi:
+    return ProcessVPERMILPSmi(X86::VPSHUFDmi);
+  case X86::VPERMILPSmi:
----------------
VPSHUFDYmi? I think this needs a AVX2 check as well


================
Comment at: llvm/lib/Target/X86/X86FixupInstTuning.cpp:117
+  case X86::VPERMILPSmi:
+    return ProcessVPERMILPSmi(X86::VPSHUFDYmi);
+  case X86::VPERMILPSZ128mi:
----------------
VPSHUFDmi


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143787/new/

https://reviews.llvm.org/D143787