[PATCH] D143645: [llvm] Fix MCSubtargetInfo::checkFeatures to handle unknown features correctly

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.



> Thanks for the comments.
>
> Even if we find some other way to address the needs of D140478 <https://reviews.llvm.org/D140478>, I think the incorrect behavior of `MCSubtargetInfo::checkFeatures` needs to be fixed.
>
> Is having no existing code referring to the use case scenario being fixed a good reason we leave the incorrect behavior in the code base as is?

I'm not sure this is incorrect behavior, though - that this function doesn't handle unknown attributes seems like it could be a valid design. If there's other ways to think about this that demonstrate that the design is not good/incorrect for existing uses, perhaps, maybe that motivates this patch regardless of D140478 <https://reviews.llvm.org/D140478>.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143645/new/

https://reviews.llvm.org/D143645