[PATCH] D144083: [JITLink] Initial AArch32 backend

Thorsten via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 24 10:42:47 PST 2023


tschuett added inline comments.


================
Comment at: llvm/include/llvm/ExecutionEngine/JITLink/aarch32.h:171
+/// Helper function to read the initial addend for Data-class relocations.
+std::optional<Expected<int64_t>> readAddendData(LinkGraph &G, Block &B,
+                                                const Edge &E);
----------------
Why do you wrap `Èxpected` with an `optional`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144083/new/

https://reviews.llvm.org/D144083



More information about the llvm-commits mailing list