[PATCH] D144125: [VPlan] VPWidenIntOrFpInductionRecipe inherits from VPHeaderPHIRecipe

Michael Maitland via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 24 10:38:39 PST 2023


michaelmaitland added a comment.

In D144125#4150975 <https://reviews.llvm.org/D144125#4150975>, @fhahn wrote:

> 



> After changing VPWidenIntOrFpInductionRecipe, are the other changes still needed?

I think this change reduces class bloat (since not all recipes are phi like, header phi like, or generate backedge). It also makes it so we only use RecipeTy in classof and uses `isa` to determine whether something `isPhi`.

I have some changes I plan to upstream in the near future that I think will give these util functions an even stronger justification for existing. If you don't think that the justifications i give are strong enough now, I am happy to remove them from this patch and include them in the future patch I mentioned.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144125/new/

https://reviews.llvm.org/D144125



More information about the llvm-commits mailing list