[PATCH] D144747: [lld][WebAssembly] Fix handling of mixed strong and weak references

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 24 10:12:54 PST 2023


sbc100 created this revision.
Herald added subscribers: pmatos, asb, wingo, ecnelises, sunfish, hiraditya, jgravelle-google, dschuff.
Herald added a project: All.
sbc100 requested review of this revision.
Herald added subscribers: llvm-commits, aheejin.
Herald added a project: LLVM.

When adding a undefined symbols to the symbol table, if the existing
reference is weak replace the symbol flags with (potentially) non-weak
binding.

Fixes: https://github.com/llvm/llvm-project/issues/60829


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D144747

Files:
  lld/test/wasm/Inputs/strong-refs.s
  lld/test/wasm/weak-undefined.s
  lld/wasm/SymbolTable.cpp
  llvm/lib/Object/WasmObjectFile.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D144747.500245.patch
Type: text/x-patch
Size: 2936 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230224/ecdef1ca/attachment.bin>


More information about the llvm-commits mailing list