[PATCH] D144125: [VPlan] VPWidenIntOrFpInductionRecipe inherits from VPHeaderPHIRecipe

[Florian Hahn via Phabricator via llvm-commits]

fhahn added a comment.

Thanks for the update! For the phi-like terminology, what matter is whether the recipe merges incoming values from different blocks.

After changing VPWidenIntOrFpInductionRecipe, are the other changes still needed?



================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:10470
           VPValue *StartVal = BestEpiPlan.getOrAddExternalDef(ResumeV);
+          assert(isa<VPHeaderPHIRecipe>(&R) && "R must be a VPHeaderPHIRecipe");
           cast<VPHeaderPHIRecipe>(&R)->setStartValue(StartVal);
----------------
that should not be needed I think, `cast` asserts that the argument isa VPHeaderPHIRecipe.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144125/new/

https://reviews.llvm.org/D144125