[PATCH] D143787: [X86] Add new pass `X86FixupInstTuning` for fixing up machine-instruction selection.

[Noah Goldstein via Phabricator via llvm-commits]

goldstein.w.n added inline comments.


================
Comment at: llvm/lib/Target/X86/X86FixupInstTuning.cpp:100
+
+  switch (Opc) {
+  case X86::VPERMILPSri:
----------------
RKSimon wrote:
> goldstein.w.n wrote:
> > RKSimon wrote:
> > > Are you intending to support the predicated variants as well? Maybe add a TODO?
> > What do you mean? For `VPERMILPS` all variants are supported I believe.
> X86::VPERMILPSZrikz etc.
Oh sure, Ill add a todo for now and make a new patch for predicate version later today.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143787/new/

https://reviews.llvm.org/D143787