[PATCH] D142068: [CostModel][RISCV] Model code size cost for reduction

[Philip Reames via Phabricator via llvm-commits]

reames accepted this revision.
reames added a comment.
This revision is now accepted and ready to land.

LGTM w/change applied.

Sorry for the delay, I missed this when first posted.



================
Comment at: llvm/lib/Target/RISCV/RISCVTargetTransformInfo.cpp:1021
+  if (CostKind == TTI::TCK_CodeSize)
+    return LT.first + BaseCost;
+
----------------
This should still be LT.first - 1


================
Comment at: llvm/lib/Target/RISCV/RISCVTargetTransformInfo.cpp:1054
+  if (CostKind == TTI::TCK_CodeSize)
+    return LT.first + BaseCost;
+
----------------
Same here


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142068/new/

https://reviews.llvm.org/D142068