[PATCH] D144083: [JITLink] Initial AArch32 backend

[Stefan Gränitz via Phabricator via llvm-commits]

sgraenitz added a comment.

@lhames I think all your feedback should be addressed now.



================
Comment at: llvm/lib/ExecutionEngine/JITLink/ELFLinkGraphBuilder.h:113
+  /// graph.
+  virtual bool excludeSectionByName(StringRef Name) const { return false; }
+
----------------
sgraenitz wrote:
> lhames wrote:
> > Is there an ELF attribute or type that we could be looking at, rather than the name?
> > 
> > (I'm very guilty of using section names rather than attributes in checks, but as JITLink evolves I do want us to use attributes and types more where possible)
> Yes this was a quick one. Let me check if I find something better. This is still open.
In a nutshell:
```
  Creating graph sections:
    ...
    4: Skipping section ".ARM.exidx" explicitly
    5: ".rel.ARM.exidx" is not an SHF_ALLOC section: No graph section will be created.
  ...
Processing relocations:
  .ARM.exidx:
    skipped (fixup section excluded explicitly)
```


================
Comment at: llvm/lib/ExecutionEngine/JITLink/ELF_aarch32.cpp:108
+      bool NameIsArmEx = *Name == ".ARM.exidx" || *Name == ".ARM.extab";
+      assert(IsArmExSection == NameIsArmEx && "Let's see if this holds");
+    });
----------------
Hope it's fine to keep this around for a bit.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144083/new/

https://reviews.llvm.org/D144083