[PATCH] D142803: [LogicCombine 1/?] Implement a general way to simplify logical operations.

[Sanjay Patel via Phabricator via llvm-commits]

spatel added inline comments.


================
Comment at: llvm/include/llvm/Analysis/LogicalExpr.h:56
+  // TODO: can we use APInt define the mask to enlarge the max leaf number?
+  uint64_t LeafMask;
+
----------------
bcl5980 wrote:
> nikic wrote:
> > Am I missing something, or is LeafMask never actually used?
> The initial patch hasn't use LeafMask. The following up change D143155 will use that. 
I did not notice that LeafMask is unused. It would be better to remove it from this patch. 

If you only add it when it becomes necessary, then we can accurately measure the cost of each enhancement. It also makes the review easier because we can see exactly where/how the new features impact the original code.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142803/new/

https://reviews.llvm.org/D142803