[PATCH] D142330: [AssumptionCache] caches @llvm.experimental.guard's

Anna Thomas via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 24 05:22:02 PST 2023


anna added a comment.

Also, this caused a miscompile when assumption cache recorded guards. Specifically, in LazyValueAnalysis, when it was used by correlated-value-propagation. Took a while to root-cause to this change, since it was a miscompile. I will add a testcase in LVI/CVP to catch this in the future.

Specifically, LVI makes a distinction between guards and assumes (in `intersectAssumeOrGuardBlockValueConstantRange`), which was not held by this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142330/new/

https://reviews.llvm.org/D142330



More information about the llvm-commits mailing list