[llvm] 736e788 - Revert "Add tests to reproduce pointer/index width confusion crashes"

Dmitri Gribenko via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 24 04:25:18 PST 2023


Author: Dmitri Gribenko
Date: 2023-02-24T13:24:51+01:00
New Revision: 736e788c58f946f236bd5c80e17eb4a5448056d5

URL: https://github.com/llvm/llvm-project/commit/736e788c58f946f236bd5c80e17eb4a5448056d5
DIFF: https://github.com/llvm/llvm-project/commit/736e788c58f946f236bd5c80e17eb4a5448056d5.diff

LOG: Revert "Add tests to reproduce pointer/index width confusion crashes"

This reverts commit 5a4f193afa0d73f7ec459648d8f02535577dd604.

See https://reviews.llvm.org/D144673, this change broke multiple
buildbots.

Added: 
    

Modified: 
    

Removed: 
    llvm/test/Transforms/LowerTypeTests/distinct-index-width-crash.ll
    llvm/test/Transforms/MergeFunc/different-index-width-gep-crash.ll
    llvm/test/Transforms/MergeICmps/X86/distinct-index-width-crash.ll


################################################################################
diff  --git a/llvm/test/Transforms/LowerTypeTests/distinct-index-width-crash.ll b/llvm/test/Transforms/LowerTypeTests/distinct-index-width-crash.ll
deleted file mode 100644
index c9a15425e8d4..000000000000
--- a/llvm/test/Transforms/LowerTypeTests/distinct-index-width-crash.ll
+++ /dev/null
@@ -1,17 +0,0 @@
-; RUN: not --crash opt -passes=lowertypetests %s -disable-output
-target datalayout = "e-p:64:64:64:32"
-
- at a = constant i32 1, !type !0
- at b = constant [2 x i32] [i32 2, i32 3], !type !1
-
-!0 = !{i32 0, !"typeid1"}
-!1 = !{i32 4, !"typeid1"}
-
-declare i1 @llvm.type.test(ptr %ptr, metadata %bitset) nounwind readnone
-
-; CHECK: @bar(
-define i1 @bar() {
-  ; CHECK: ret i1 true
-  %x = call i1 @llvm.type.test(ptr getelementptr ([2 x i32], ptr @b, i32 0, i32 1), metadata !"typeid1")
-  ret i1 %x
-}

diff  --git a/llvm/test/Transforms/MergeFunc/
diff erent-index-width-gep-crash.ll b/llvm/test/Transforms/MergeFunc/
diff erent-index-width-gep-crash.ll
deleted file mode 100644
index 8644493a7e4e..000000000000
--- a/llvm/test/Transforms/MergeFunc/
diff erent-index-width-gep-crash.ll
+++ /dev/null
@@ -1,13 +0,0 @@
-; RUN: not --crash opt -disable-output -passes=mergefunc -S < %s
-
-target datalayout = "e-p:64:64-p2:128:128:128:32"
-
-define void @foo(ptr addrspace(2) %x) {
-    %tmp = getelementptr i32, ptr addrspace(2) %x, i32 1
-    ret void
-}
-
-define void @bar(ptr addrspace(2) %x) {
-    %tmp = getelementptr i32, ptr addrspace(2) %x, i32 1
-    ret void
-}

diff  --git a/llvm/test/Transforms/MergeICmps/X86/distinct-index-width-crash.ll b/llvm/test/Transforms/MergeICmps/X86/distinct-index-width-crash.ll
deleted file mode 100644
index 78c04b48f206..000000000000
--- a/llvm/test/Transforms/MergeICmps/X86/distinct-index-width-crash.ll
+++ /dev/null
@@ -1,32 +0,0 @@
-; RUN: not --crash opt < %s -passes=mergeicmps -verify-dom-info -disable-output
-
-target triple = "x86_64"
-
-; This is very much not an x86 ABI, in current use, but we're testing
-; that we've fixed a bug where accumulateConstantOffset() was called incorrectly.
-target datalayout = "e-p:64:64:64:32"
-
-; Define a cunstom data layout that has index width < pointer width
-; and make sure that doesn't mreak anything
-define void @fat_ptrs(ptr dereferenceable(16) %a, ptr dereferenceable(16) %b) {
-bb0:
-  %ptr_a1 = getelementptr inbounds [2 x i64], ptr %a, i64 0, i64 1
-  %ptr_b1 = getelementptr inbounds [2 x i64], ptr %b, i64 0, i64 1
-  br label %bb1
-
-bb1:                                              ; preds = %bb0
-  %a0 = load i64, ptr %a
-  %b0 = load i64, ptr %b
-  %cond0 = icmp eq i64 %a0, %b0
-  br i1 %cond0, label %bb2, label %bb3
-
-bb2:                                              ; preds = %bb1
-  %a1 = load i64, ptr %ptr_a1
-  %b1 = load i64, ptr %ptr_b1
-  %cond1 = icmp eq i64 %a1, %b1
-  br label %bb3
-
-bb3:                                              ; preds = %bb2, %bb1
-  %necessary = phi i1 [ %cond1, %bb2 ], [ false, %bb1 ]
-  ret void
-}


        


More information about the llvm-commits mailing list