[PATCH] D143645: [llvm] Fix MCSubtargetInfo::checkFeatures to handle unknown features correctly

[Venkata Ramanaiah Nalamothu via Phabricator via llvm-commits]

RamNalamothu added a comment.

In D143645#4148087 <https://reviews.llvm.org/D143645#4148087>, @dblaikie wrote:

> Is this new behavior visible through some existing non-test callers of `MCSubtargetInfo::checkFeatures`? Could that be tested using a lit-style test to demonstrate that this behavior is desirable/correct at that scope, beyond the narrower unit test?

Without this change, few lit tests will fail with the updated changeset for D140478 <https://reviews.llvm.org/D140478>. Would that be sufficient to showcase that this change is needed?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143645/new/

https://reviews.llvm.org/D143645