[PATCH] D144714: [JITLink] Introduce virtual offsets for Symbol definitions in LinkGraph

[Stefan Gränitz via Phabricator via llvm-commits]

sgraenitz added a comment.

This implementation is one option. Symbols don't know their target triple, but the link-graph does. My main concern is that `splitArchVirtualOffset()` would introduce target-specific behavior to `LinkGraph`. Not sure how we could avoid it without changing the interface.

The alternative I see would be to extend the `LinkGraph::add<...>Symbol()` interface and:
(1) either add `VirtualOffset` as another parameter -- currently affects around 80 individual calls
(2) or add respective overloads where necessary -- affects no-one but adds extra overall complexity to the interface

What do you think?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144714/new/

https://reviews.llvm.org/D144714