[PATCH] D143115: [lld][RISCV] Introduce handling for R_RISCV_PLT32 relocation

Alex Bradbury via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 24 01:03:26 PST 2023


asb added a comment.

@kito-cheng @jrtc27: Can I just confirm the ABI development process? We obviously went through a whole ratification exercise before, but how does it now work for these kind of additions? I'm mainly concerned about merging support for something that's added to the psABI doc, but then having to change it later if it's viewed as not "final". I guess this shouldn't happen, as a consequence of the PR merging policy <https://github.com/riscv-non-isa/riscv-elf-psabi-doc/blob/master/policy.md> but it's still a bit unclear how it intersects with any future ratification process that might be requested by RISC-V International.

Though FWIW, I think the path of getting broad consensus on the proposal and then considering it 'done' is just fine - I'm not sure extra layers of sign-off would be helpful for incremental improvements like this. And in case I missed a hidden layer of bureaucracy, I _think_ the x86_64 psABI is evolved in a similar way.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143115/new/

https://reviews.llvm.org/D143115



More information about the llvm-commits mailing list