[PATCH] D137092: [llvm-readobj] Use a helper to extract the Other Flags from symbols

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:3256
+  if (Header.e_machine == EM_MIPS) {
+    // Someones in their infinite wisdom decided to make STO_MIPS_MIPS16
+    // flag overlapped with other ST_MIPS_xxx flags. So consider both
----------------
Whilst moving this line, please fix the "Somones" typo (it should be "Someone").


================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:3257
+    // Someones in their infinite wisdom decided to make STO_MIPS_MIPS16
+    // flag overlapped with other ST_MIPS_xxx flags. So consider both
+    // cases separately.
----------------
Same logic as above.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137092/new/

https://reviews.llvm.org/D137092