[PATCH] D143787: [X86] Add new pass `X86FixupInstTuning` for fixing up machine-instruction selection.

Noah Goldstein via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 23 20:10:10 PST 2023


goldstein.w.n marked 2 inline comments as done.
goldstein.w.n added inline comments.


================
Comment at: llvm/lib/Target/X86/X86FixupInstTuning.cpp:100
+
+  switch (Opc) {
+  case X86::VPERMILPSri:
----------------
RKSimon wrote:
> Are you intending to support the predicated variants as well? Maybe add a TODO?
What do you mean? For `VPERMILPS` all variants are supported I believe.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143787/new/

https://reviews.llvm.org/D143787



More information about the llvm-commits mailing list