[PATCH] D143437: [llvm] Use pointer index type for more GEP offsets (pre-codegen)

Alexander Richardson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 23 15:44:59 PST 2023


arichardson accepted this revision.
arichardson added a comment.
This revision is now accepted and ready to land.

I would check the output of the no longer crashing tests but otherwise LGTM. Please wait for @arsenm to confirm as well before committing though.



================
Comment at: llvm/test/Transforms/MergeICmps/X86/distinct-index-width-crash.ll:1
-; RUN: not --crash opt < %s -passes=mergeicmps -verify-dom-info -disable-output
+; RUN: opt < %s -passes=mergeicmps -verify-dom-info -disable-output
 
----------------
Maybe also check the output here to make sure it's somewhat sensible?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143437/new/

https://reviews.llvm.org/D143437



More information about the llvm-commits mailing list