[PATCH] D144675: [X86] Move atomics test for !pcsections into separate file
Marco Elver via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Feb 23 14:42:08 PST 2023
melver created this revision.
melver added reviewers: dvyukov, vitalybuka.
Herald added a subscriber: pengfei.
Herald added a project: All.
melver requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
The pcsections.ll test primarily tests that the AsmPrinter produces the
right output in sections. This output is not easily covered by
update_llc_test_checks.py, and as such is hand written. This makes
maintenance rather burdensome. Instead, let's keep pcsections.ll as
simple as possible.
Move the more complex tests that primarily test that some atomic
operations end up in the PC section to pcsections-atomics.ll. Extend the
test to exhaustively cover all atomic ops up to 64 bits.
This currently shows that some atomic operations do not end up in PC
sections. This will be addressed in a subsequent change.
NFC.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D144675
Files:
llvm/test/CodeGen/X86/pcsections-atomics.ll
llvm/test/CodeGen/X86/pcsections.ll
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D144675.499982.patch
Type: text/x-patch
Size: 289924 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230223/cbd67e22/attachment-0001.bin>
More information about the llvm-commits
mailing list