[PATCH] D144672: [Sanitizers] Error when attempting to use `static-lsan` with `tsan` or `asan` on darwin

[Usama Hameed via Phabricator via llvm-commits]

usama54321 added inline comments.


================
Comment at: b/llvm/llvm-project/clang/include/clang/Basic/DiagnosticDriverKinds.td  :228
+def err_drv_unsupported_static_asan_darwin : Error<
+  "static AddressSanitizer runtime is not supported on darwin">;
 def err_drv_duplicate_config : Error<
----------------
yln wrote:
> Should we generalize this to "static sanitizer runtimes are not supported on Apple platforms" to avoid needing an error diagnostic for every tool?
I would suggest replacing the name with a placeholder so we only need one definition here.


================
Comment at: b/llvm/llvm-project/clang/include/clang/Driver/Options.td       :1218
 def static_libsan : Flag<["-"], "static-libsan">,
-  HelpText<"Statically link the sanitizer runtime">;
+  HelpText<"Statically link the sanitizer runtime (Not supported for asan, tsan or ubsan on Apple platforms)">;
 def : Flag<["-"], "shared-libasan">, Alias<shared_libsan>;
----------------
I see asan capitalized as ASan in another help text in this file. I will suggest conforming the capitalization accordingly for the 3 names. Also, I'd suggest changing Apple platforms to Darwin platforms or just darwin.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144672/new/

https://reviews.llvm.org/D144672