[PATCH] D144596: Add extra parameter to thinlto-prefix-replace

Jez Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 23 13:17:36 PST 2023


int3 added inline comments.


================
Comment at: lld/test/MachO/thinlto-index-file-object-prefix-replace.ll:3
+; RUN: rm -rf %t ; split-file %s %t && cd %t
+; RUN: mkdir -p oldpath oldpath/prefix_replace
+
----------------
itf wrote:
> oontvoo wrote:
> > This needs to go under `%t` (otherwise the tests may fail in our integrates because only stuff under `%t` is writeable)
> is `cd %t` in the previous line not enough to keep the following commands under `%t` ?
It is. However, none of the other tests do this, so I would prefer we avoid it unless it's required by the nature of this test


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144596/new/

https://reviews.llvm.org/D144596



More information about the llvm-commits mailing list