[PATCH] D143018: [DAGCombiner][NFC] Factor out ByteProvider

[Thorsten via Phabricator via llvm-commits]

tschuett added inline comments.


================
Comment at: llvm/include/llvm/ADT/ByteProvider.h:26
+// Does this type correspond with an operation in selection DAG
+template <typename T> struct is_op {
+private:
----------------
Why struct, when you use private and public?


================
Comment at: llvm/include/llvm/ADT/ByteProvider.h:29
+  typedef std::true_type yes;
+  typedef std::false_type no;
+
----------------
using instead of typedef?


================
Comment at: llvm/include/llvm/ADT/ByteProvider.h:51
+/// are used to extract Bytes.
+template <typename T> struct ByteProvider {
+  // For constant zero providers Src is set to nullopt. For actual providers
----------------
Why struct?


================
Comment at: llvm/include/llvm/ADT/ByteProvider.h:93
+#endif // LLVM_ADT_BYTEPROVIDER_H
\ No newline at end of file

----------------
Newline missing


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143018/new/

https://reviews.llvm.org/D143018