[PATCH] D144354: [WebAssembly] Split WebAssemblyUtils to fix library layering for MC tools.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.

LGTM. Note that there is unresolved comment about enable-emscripten-cxx-exceptions and its friends belonging to the CodeGen part rather than the MC part.



================
Comment at: llvm/lib/Target/WebAssembly/MCTargetDesc/WebAssemblyMCUtilities.cpp:34
+                              cl::desc("WebAssembly exception handling"),
+                              cl::init(false));
+// setjmp/longjmp handling using wasm EH instrutions
----------------
Drop `, cl::init(false)` (default)


================
Comment at: llvm/lib/Target/WebAssembly/MCTargetDesc/WebAssemblyMCUtilities.h:20
+
+namespace llvm {
+
----------------
With C++17 we can use `namespace llvm::WebAssembly`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144354/new/

https://reviews.llvm.org/D144354