[PATCH] D144612: [AMDGPU] Move V_FMA_MIX pattern matching into tablegen. NFC
Justin Bogner via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Feb 23 10:25:38 PST 2023
bogner marked an inline comment as done.
bogner added inline comments.
================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp:555
-
- // TODO: We can select this with f32 denormals enabled if all the sources are
- // converted from f16 (in which case fmad isn't legal).
----------------
foad wrote:
> Is it worth preserving the TODO somewhere?
I added a TODO about handling of denormals in general in the version I pushed.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144612/new/
https://reviews.llvm.org/D144612
More information about the llvm-commits
mailing list